Fix build with clang on linux #1805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would do this a different way. First add a CI job that tests for clang builds, and have that fail. Then add the fix. a matrix thing in https://github.com/falkTX/Carla/blob/main/.github/workflows/build.yml should do the trick, I can add one soon. |
vimproved
force-pushed
the
clang-linux
branch
5 times, most recently
from
809da01
to
7c3315b
Compare
Signed-off-by: Violet Purcell <vimproved@inventati.org>
Signed-off-by: Violet Purcell <vimproved@inventati.org>
|
@falkTX I modified this PR to add a clang CI, and also to automatically detect compiler based on |
falkTX
force-pushed
the
main
branch
13 times, most recently
from
edcab1c
to
903ad4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang does not support the -fno-gnu-unique argument. Previously this was not added if BSD was true (presumably to work around FreeBSD support) but there is a CLANG variable serving that purpose. Use that instead.