Import fixes from main branch

Signed-off-by: falkTX <falktx@falktx.com>
falkTX · Aug 19, 2024 · c16c8ed · c16c8ed
1 parent 2f5bd5c
commit c16c8ed
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 8 deletions.
diff --git a/source/bridges-plugin/Makefile b/source/bridges-plugin/Makefile
@@ -177,6 +177,7 @@ NATIVE_LINK_FLAGS  += $(LIBLO_LIBS)
 NATIVE_BUILD_FLAGS += $(FLUIDSYNTH_FLAGS)
 NATIVE_LINK_FLAGS  += $(FLUIDSYNTH_LIBS)
 
+NATIVE_BUILD_FLAGS += $(MAGIC_FLAGS)
 NATIVE_LINK_FLAGS  += $(MAGIC_LIBS)
 
 LIBS_native        += $(MODULEDIR)/audio_decoder.a

diff --git a/source/frontend/patchcanvas/canvasport.py b/source/frontend/patchcanvas/canvasport.py
@@ -120,7 +120,16 @@ def setPortType(self, port_type):
         self.update()
 
     def setPortName(self, port_name):
-        if QFontMetrics(self.m_port_font).width(port_name) < QFontMetrics(self.m_port_font).width(self.m_port_name):
+        metrics = QFontMetrics(self.m_port_font)
+
+        if QT_VERSION >= 0x50b00:
+            width1 = metrics.horizontalAdvance(port_name)
+            width2 = metrics.horizontalAdvance(self.m_port_name)
+        else:
+            width1 = metrics.width(port_name)
+            width2 = metrics.width(self.m_port_name)
+
+        if width1 < width2:
             QTimer.singleShot(0, canvas.scene.update)
 
         self.m_port_name = port_name

diff --git a/source/frontend/widgets/canvaspreviewframe.py b/source/frontend/widgets/canvaspreviewframe.py
@@ -207,7 +207,7 @@ def mouseReleaseEvent(self, event):
         if event.button() == Qt.LeftButton:
             event.accept()
             self.fMouseLeftDown = False
-            self._updateMouseMode()
+            self._updateMouseMode(event)
             return
         if event.button() == Qt.RightButton:
             event.accept()
@@ -386,7 +386,7 @@ def _scaleViewRect(self, globalY: int):
 
         self.cursor().setPos(self.fMouseInitialZoomPos)
 
-    def _updateMouseMode(self, event = None):
+    def _updateMouseMode(self, event):
         if self.fMouseLeftDown and self.fMouseRightDown:
             self.fMouseInitialZoomPos = event.globalPos()
             self.setCursor(self.fZoomCursors[self._kCursorZoom])

diff --git a/source/frontend/widgets/pixmapdial.py b/source/frontend/widgets/pixmapdial.py
@@ -72,8 +72,9 @@ def updateSizes(self):
             self.fLabelWidth  = 0
             return
 
-        self.fLabelWidth  = QFontMetrics(self.fLabelFont).width(self.fLabel)
-        self.fLabelHeight = QFontMetrics(self.fLabelFont).height()
+        metrics = QFontMetrics(self.fLabelFont)
+        self.fLabelWidth  = fontMetricsHorizontalAdvance(metrics, self.fLabel)
+        self.fLabelHeight = metrics.height()
 
         self.fLabelPos.setX(float(self.fPixmapBaseSize)/2.0 - float(self.fLabelWidth)/2.0)
 

diff --git a/source/frontend/widgets/scalabledial.py b/source/frontend/widgets/scalabledial.py
@@ -76,8 +76,9 @@ def updateSizes(self):
             self.fLabelWidth  = 0
             return
 
-        self.fLabelWidth  = QFontMetrics(self.fLabelFont).width(self.fLabel)
-        self.fLabelHeight = QFontMetrics(self.fLabelFont).height()
+        metrics = QFontMetrics(self.fLabelFont)
+        self.fLabelWidth  = fontMetricsHorizontalAdvance(metrics, self.fLabel)
+        self.fLabelHeight = metrics.height()
 
         self.fLabelPos.setX(float(self.fImageBaseSize)/2.0 - float(self.fLabelWidth)/2.0)
 
@@ -281,7 +282,6 @@ def paintDial(self, painter):
 
             # Custom knobs
             else:
-                painter.restore()
                 return
 
             if self.HOVER_MIN < self.fHoverStep < self.HOVER_MAX: