Field properties changes #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on: Hold until those get merged. |
|
/retest |
This matches the corresponding sdk change in falcosecurity/plugin-sdk-go#32. The sdk change should be merged first. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
This changes the syntax of field Properties to be a list instead of a single value. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
mstemm
force-pushed
the
field-properties-changes
branch
from
1e017ca to
d91bbed
Compare
This allows for field properties as a list of strings. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
Not explicitly required, as this plugin doesn't actually export field properties, but just for consistency. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
When defining a field, add a properties property with a list of string values. Also serialize this to json in the ostringstream overload. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
leogr
approved these changes
Jan 14, 2022
|
LGTM label has been added. Git tree hash: 19c0d1d42e3d92943de1277e2c85b146fe40c82b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area source-plugins
/area extractor-plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: