Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use base name in docker-entrypoint.sh #981

Merged
merged 3 commits into from
Feb 26, 2020
Merged

fix: use base name in docker-entrypoint.sh #981

merged 3 commits into from
Feb 26, 2020

Conversation

aarroyoc
Copy link
Contributor

@aarroyoc aarroyoc commented Dec 18, 2019

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

It uses the base path in the docker-entrypoint.sh. This is needed because when you build Falco from source along with the driver, it tries to create a link with destination /usr/src//host/usr/src/XXX which is wrong and should be /usr/src/XXX

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(docker): use base name in docker-entrypoint.sh

aarroyoc and others added 3 commits January 24, 2020 14:09
Signed-off-by: Adrián Arroyo Calle <adrian.arroyocalle@gmail.com>
Signed-off-by: Adrián Arroyo Calle <adrian.arroyocalle@gmail.com>
…entrypoint

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana added size/S and removed size/XS labels Jan 24, 2020
@fntlnz fntlnz changed the base branch from dev to master February 3, 2020 15:15
@poiana
Copy link
Contributor

poiana commented Feb 4, 2020

LGTM label has been added.

Git tree hash: 8bd693c495e77c8bd221e410fbc44967e3d77367

@poiana poiana added the approved label Feb 4, 2020
@aarroyoc
Copy link
Contributor Author

I thought this was included in Falco 0.20, but no, and I still get the same error that made me create this PR:

cxb0290@mac-510116 baikal2 % k logs falco-7c9wn falco -n baikal-system
* Setting up /usr/src links from host
ln: failed to create symbolic link '/usr/src//host/usr/src/linux-azure-headers-4.15.0-1066': No such file or directory
ln: failed to create symbolic link '/usr/src//host/usr/src/linux-azure-headers-4.15.0-1071': No such file or directory
ln: failed to create symbolic link '/usr/src//host/usr/src/linux-headers-4.15.0-1066-azure': No such file or directory
ln: failed to create symbolic link '/usr/src//host/usr/src/linux-headers-4.15.0-1071-azure': No such file or directory
* Unloading falco-probe, if present
* Running dkms install for falco
Error! echo
Your kernel headers for kernel 4.15.0-1066-azure cannot be found at
/lib/modules/4.15.0-1066-azure/build or /lib/modules/4.15.0-1066-azure/source.
* Running dkms build failed, couldn't find /var/lib/dkms/falco/0.20.0+d77080a/build/make.log
* Trying to load a system falco-probe, if present
* Trying to find precompiled falco-probe for 4.15.0-1066-azure
Found kernel config at /host/boot/config-4.15.0-1066-azure
* Trying to download precompiled module from https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/falco-probe-0.20.0%2Bd77080a-x86_64-4.15.0-1066-azure-c07e1b0c69c599054b906a7da9e219bb.ko
curl: (22) The requested URL returned error: 404 Not Found
Download failed, consider compiling your own falco-probe and loading it or getting in touch with the Falco community
2020-02-24T17:43:31+0000: Falco initialized with configuration file /etc/falco/falco.yaml
2020-02-24T17:43:31+0000: Loading rules from file /etc/falco/falco_rules.yaml:
2020-02-24T17:43:31+0000: Unable to load the driver. Exiting.

(Check the first lines)

@fntlnz
Copy link
Contributor

fntlnz commented Feb 25, 2020

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Feb 25, 2020
@fntlnz
Copy link
Contributor

fntlnz commented Feb 25, 2020

Thanks @aarroyoc ! This looks very good :)

@poiana
Copy link
Contributor

poiana commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz
Copy link
Contributor

fntlnz commented Feb 26, 2020

reopening to let poiana take this

@fntlnz fntlnz closed this Feb 26, 2020
@fntlnz fntlnz reopened this Feb 26, 2020
@poiana poiana merged commit 2a73936 into falcosecurity:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants