-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use base name in docker-entrypoint.sh #981
Conversation
Signed-off-by: Adrián Arroyo Calle <adrian.arroyocalle@gmail.com>
Signed-off-by: Adrián Arroyo Calle <adrian.arroyocalle@gmail.com>
…entrypoint Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
LGTM label has been added. Git tree hash: 8bd693c495e77c8bd221e410fbc44967e3d77367
|
I thought this was included in Falco 0.20, but no, and I still get the same error that made me create this PR:
(Check the first lines) |
/milestone 0.21.0 |
Thanks @aarroyoc ! This looks very good :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
reopening to let poiana take this |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
It uses the base path in the docker-entrypoint.sh. This is needed because when you build Falco from source along with the driver, it tries to create a link with destination /usr/src//host/usr/src/XXX which is wrong and should be /usr/src/XXX
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: