Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump libs and driver, and adopt unique pointers wherever possible #3109

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

jasondellaluce
Copy link
Contributor

@jasondellaluce jasondellaluce commented Feb 22, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This follows up falcosecurity/libs#1702 in libs by bumping the dependencies and by adapting the code. To continue the effort, raw pointers have been removed from the Falco app wherever possible too.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@FedeDP
Copy link
Contributor

FedeDP commented Feb 22, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Feb 22, 2024
FedeDP
FedeDP previously approved these changes Feb 22, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!
/approve

@poiana
Copy link
Contributor

poiana commented Feb 22, 2024

LGTM label has been added.

Git tree hash: 72a8a42762824b48b6d0d369e68df5b907bc53db

jasondellaluce and others added 3 commits February 23, 2024 08:35
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Feb 23, 2024
@poiana
Copy link
Contributor

poiana commented Feb 23, 2024

LGTM label has been added.

Git tree hash: b6cb7996fb3623e89896fb8e017be7546a6d3b1d

@jasondellaluce
Copy link
Contributor Author

/unhold

@poiana
Copy link
Contributor

poiana commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 02ad182 into master Feb 23, 2024
29 checks passed
@poiana poiana deleted the refactor/reduce-raw-ptrs branch February 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants