chore(build): allow usage of non-bundled nlohmann-json #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
federico-sysdig
force-pushed
the
build-allow-non-bundled-nlohmann-json
branch
from
49c5cf7 to
b2a59e6
Compare
|
LGTM label has been added. Git tree hash: 563457448b909b575c8e29886d8843c85d697565
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Library
nlohmann-jsonwas always downloaded as part of the build and didn't follow the choice bundled/non-bundled of the other ones. This PR adds the CMake variableUSE_BUNDLED_NLOHMANN_JSONto allow just that.Some improvements in the way the library is referenced have also been applied to follow a more modern CMake usage: typically using
find_packageto look for the library and linking it with the CMake aliasnlohmann_json::nlohmann_jsonthat the library maintainers have chosen.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: