Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(docker): updated falco-builder to fix multiarch support. #2049

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 8, 2022

Signed-off-by: Federico Di Pierro nierro92@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

With @leogr , we already pushed the updated images on dockerhub: https://hub.docker.com/r/falcosecurity/falco-builder/tags

  • x86_64 2d1391e4feb0d39f340f9431fd2f83dae968db72cb5f16113965193c1b920943
  • aarch64 97f45baa58234534c975b2487a8f71f31c47485d562fad7c99d7a6e0894c54fe

Does this PR introduce a user-facing change?:

NONE

@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 8, 2022
@FedeDP FedeDP force-pushed the new/falco_builder_multiarch branch 2 times, most recently from 1d3ac52 to a0b3a26 Compare June 9, 2022 06:48
leogr
leogr previously approved these changes Jun 9, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Jun 9, 2022
@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

LGTM label has been added.

Git tree hash: 6bfddb70c0677fb1b4d676fb2d845d5aeb4b8ee6

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
@FedeDP FedeDP force-pushed the new/falco_builder_multiarch branch from a0b3a26 to 6c22fa0 Compare June 9, 2022 06:56
@poiana poiana removed the lgtm label Jun 9, 2022
@poiana poiana requested a review from leogr June 9, 2022 06:56
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

LGTM label has been added.

Git tree hash: cd6ed41f7ff32158bc82d37d09ec4e6ad53e40d0

@poiana poiana added the approved label Jun 9, 2022
@poiana poiana merged commit a98bf52 into falcosecurity:master Jun 9, 2022
@FedeDP FedeDP deleted the new/falco_builder_multiarch branch June 9, 2022 07:33
@jasondellaluce jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants