Improvements to the integration tests build #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
This make target calls the `trace-files-psp`, `trace-files-k8s-audit`, `trace-files-base-scap` targets to place all the integration test fixtures in the proper position. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…t suites Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…suite Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
options The following options have been added: * -v (verbose) * -p (prepare falco_traces test suite) * -b (specify custom branch for downloading trace files) * -d (specify the build directory) Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…uite locally Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…ite in a non-interactive way Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
commented
Jul 14, 2020
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
|
/hold cancel |
leogr
reviewed
Jul 20, 2020
There was a problem hiding this comment.
SGTM,
though I still got some errors.
- When running locally using
virtualenvandfalco_test.yaml, although I executed all preparation steps (including ones forfalco_traces),
virtualenv venv
source venv/bin/activate
pip install -r requirements.txt
BUILD_DIR="../build" avocado run --mux-yaml falco_tests.yaml --job-results-dir /tmp/job-results -- falco_test.py
deactivate
just one test is not passing:
(83/96) falco_test.py:FalcoTest.test;in_operator_netmasks-ea28: ERROR: Falco command "../build/userspace/falco/falco -r /home/leogr/code/github.com/falcosecurity/falco/test/rules/detect_connect_using_in.yaml -c /home/leogr/code/github.com/falcosecurity/falco/test/../falco.yaml -e ../build/test/trace_files/connect_localhost... (0.36 s)
- Also, when using
./run_regression_tests.sh -valthough I executed all preparation (including ones forfalco_tests_package) many tests are not passing.
I'm still investigating to figure out the problems
|
Verify your local build is a |
fntlnz
previously approved these changes
Jul 20, 2020
|
LGTM label has been added. Git tree hash: a84fd9c3ece72a7d70b52137243cb50ea08e5f39
|
leogr
reviewed
Jul 20, 2020
…ild of Falco Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com> Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Merged
fntlnz
approved these changes
Jul 20, 2020
|
LGTM label has been added. Git tree hash: 2cd60f1671d7db0e4b39d9d27d83a3e6ecb06f4c
|
Kaizhe
approved these changes
Jul 20, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, Kaizhe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
poiana
added
do-not-merge/release-note-label-needed
release-note
and removed
release-note
do-not-merge/release-note-label-needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
/kind feature
Any specific area of the project related to this PR?
/area build
/area tests
What this PR does / why we need it:
run_regression_tests.shscriptfalcosecurity/falco-testerimageupdate-integration-tests-build)falcosecurity/falco-tester:update-integration-tests-buildimagelatestand switch back the CI to normal flowrun_regression_tests.shchanges into the Falco website (update instructions to run integration test locally falco-website#227)Which issue(s) this PR fixes:
Special notes for your reviewer:
Ready for review.
/cc @fntlnz
/cc @leogr
Does this PR introduce a user-facing change?: