new(falco): adding imagePullSecrets at the service account level #824
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Íñigo <megalucio@users.noreply.github.com>
poiana
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: megalucio The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
For most use cases, it is recommended to specify imagePullSecrets at the ServiceAccount level if all pods using that ServiceAccount need access to the same image pull secrets. This approach simplifies management and ensures consistency across your deployments.
This pull request includes updates to the Falco Helm Chart to add support for image pull secrets at the service account level. The most important changes include updating the chart version, adding a new configuration option for image pull secrets, and documenting this new feature.
Feature Addition:
charts/falco/templates/serviceaccount.yaml: Added the ability to specifyimagePullSecretsfor the service account.charts/falco/values.yaml: Introduced a new configuration optionserviceAccount.imagePullSecretsto support credentials for pulling images from private registries.Documentation Updates:
charts/falco/README.md: Updated the table of configurable parameters to includeserviceAccount.imagePullSecrets.charts/falco/CHANGELOG.md: Documented the new feature in the changelog for version 4.19.1.Version Bump:
charts/falco/Chart.yaml: Bumped the chart version from 4.19.0 to 4.19.1.Which issue(s) this PR fixes:
Special notes for your reviewer:
I've already fixed the corrisponding labels in GitHub
Checklist