Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat falcosidekick dashboard v2 #809

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cobcan
Copy link
Contributor

@cobcan cobcan commented Dec 27, 2024

New update on the falcosidekick dashboard for loki, added some filtering options. Working with this dashboard I notice this filtering options are a must to have.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area falco-talon-chart

/area event-generator-chart

/area k8s-metacollector-chart

What this PR does / why we need it:
Added filtering options (priority and line filters) to the falcosidekick dashboard
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I've already fixed the corrisponding labels in GitHub

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

New update on the falcosidekick dashboard for loki, added some filtering options

Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
@poiana poiana requested review from bencer and leogr December 27, 2024 19:37
@poiana poiana added the size/L label Dec 27, 2024
@leogr leogr requested a review from Issif January 7, 2025 11:17
@Issif Issif self-assigned this Jan 7, 2025
}
]
},
"time": {
"from": "now-30m",
"from": "now-4d",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be little to much data, last 24h max seems better to me, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 24h seems resonable. In the test enviroment I use it only has about 10k logs per day. I didn't thought that in some systems could reach to millions per day. I'll change it.

@poiana
Copy link
Contributor

poiana commented Jan 8, 2025

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

get logs from 24h ago instead of 4d ago

Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
@Issif
Copy link
Member

Issif commented Jan 16, 2025

Can you fix the merge conflict by upgrading the version and the Changelog to 0.9.6, please

Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
Issif
Issif previously approved these changes Jan 17, 2025
@poiana poiana added the lgtm label Jan 17, 2025
@poiana
Copy link
Contributor

poiana commented Jan 17, 2025

LGTM label has been added.

Git tree hash: 2656c8086ab47e493e5fffe66311b4e9454abfdf

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to update the version in the Chart.yaml and run make docs-falcosidekick to update the readme.

@poiana poiana removed the approved label Jan 22, 2025
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
@cobcan cobcan force-pushed the feat-falcosidekick-dashboard-v2 branch from 154c671 to c5367e9 Compare January 23, 2025 19:31
@poiana poiana added the lgtm label Jan 27, 2025
@poiana
Copy link
Contributor

poiana commented Jan 27, 2025

LGTM label has been added.

Git tree hash: 618e7fb4c03ffbb4d0d0becb7e2b9756244197dd

@poiana
Copy link
Contributor

poiana commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cobcan, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants