-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat falcosidekick dashboard v2 #809
base: master
Are you sure you want to change the base?
Feat falcosidekick dashboard v2 #809
Conversation
New update on the falcosidekick dashboard for loki, added some filtering options Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
} | ||
] | ||
}, | ||
"time": { | ||
"from": "now-30m", | ||
"from": "now-4d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be little to much data, last 24h max seems better to me, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah 24h seems resonable. In the test enviroment I use it only has about 10k logs per day. I didn't thought that in some systems could reach to millions per day. I'll change it.
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
get logs from 24h ago instead of 4d ago Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
Can you fix the merge conflict by upgrading the version and the Changelog to 0.9.6, please |
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
LGTM label has been added. Git tree hash: 2656c8086ab47e493e5fffe66311b4e9454abfdf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to update the version in the Chart.yaml and run make docs-falcosidekick
to update the readme.
Signed-off-by: Alfonso Cobo Canela <165585176+cobcan@users.noreply.github.com>
154c671
to
c5367e9
Compare
LGTM label has been added. Git tree hash: 618e7fb4c03ffbb4d0d0becb7e2b9756244197dd
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cobcan, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New update on the falcosidekick dashboard for loki, added some filtering options. Working with this dashboard I notice this filtering options are a must to have.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
Added filtering options (priority and line filters) to the falcosidekick dashboard
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I've already fixed the corrisponding labels in GitHub
Checklist