-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typing): type App classes #2286
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2286 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 7330 7410 +80
Branches 1276 1278 +2
=========================================
+ Hits 7330 7410 +80 ☔ View full report in Codecov by Sentry. |
sorry for the force push + squash, but it was starting to become a mess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now bar these triple '''
docstrings, I regret even starting that discussion 🤣
But we can revise them later, no need to block the whole PR.
CodeCov is hallucinating as usual, but I have manually verified coverage by running tox
on your branch.
I actually think it's a lot nicer for reading the source code. Having to escape the """ is quite ugly |
This is a follow up of ##2271