Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typing): type App classes #2286

Merged
merged 1 commit into from
Aug 30, 2024
Merged

feat(typing): type App classes #2286

merged 1 commit into from
Aug 30, 2024

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Aug 20, 2024

This is a follow up of ##2271

@CaselIT CaselIT marked this pull request as ready for review August 20, 2024 20:51
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e5ada2f) to head (9ed7475).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2286   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7330      7410   +80     
  Branches      1276      1278    +2     
=========================================
+ Hits          7330      7410   +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 changed the title Type app classes feat(typing): type App classes Aug 21, 2024
@CaselIT CaselIT requested a review from vytas7 August 27, 2024 17:09
@CaselIT
Copy link
Member Author

CaselIT commented Aug 27, 2024

sorry for the force push + squash, but it was starting to become a mess

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now bar these triple ''' docstrings, I regret even starting that discussion 🤣
But we can revise them later, no need to block the whole PR.

CodeCov is hallucinating as usual, but I have manually verified coverage by running tox on your branch.

@vytas7 vytas7 merged commit 5f7edf0 into falconry:master Aug 30, 2024
37 of 39 checks passed
@CaselIT CaselIT deleted the type_app branch August 30, 2024 06:05
@CaselIT
Copy link
Member Author

CaselIT commented Aug 30, 2024

Thanks, LGTM now bar these triple ''' docstrings, I regret even starting that discussion 🤣

I actually think it's a lot nicer for reading the source code. Having to escape the """ is quite ugly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants