Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(util.uri): refactor dict comprehension #1783

Merged
merged 14 commits into from
Dec 19, 2020
Merged

refactor(util.uri): refactor dict comprehension #1783

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5918707
Initial fixes and formatting using autopep8
deepsourcebot Nov 13, 2020
f8857b7
revert fixes and updated master with upstream branch
withshubh Dec 10, 2020
e1e67de
Add .deepsource.toml
deepsourcebot Dec 10, 2020
4e8eb7a
Use literal syntax instead of function calls to create data structure
deepsource-autofix[bot] Dec 10, 2020
5a7b335
Remove unnecessary generator
deepsource-autofix[bot] Dec 10, 2020
02ca75d
Replace ternary syntax with if expression
deepsource-autofix[bot] Dec 10, 2020
a30357d
Merge pull request #36 from withshubh/deepsource1
withshubh Dec 10, 2020
5c27267
Merge branch 'master' into master
withshubh Dec 10, 2020
738e8bb
revert fix - Use literal syntax instead of function calls to create d…
withshubh Dec 11, 2020
ee7a7a6
Merge pull request #37 from withshubh/deepsource1
withshubh Dec 11, 2020
5433166
Delete .deepsource.toml
withshubh Dec 11, 2020
6589626
Update .gitignore
withshubh Dec 11, 2020
944042e
fixed pep8 voilation occuring in ci check
withshubh Dec 19, 2020
e6d4681
Merge branch 'master' into master
vytas7 Dec 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions falcon/util/uri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@
_HEX_DIGITS = '0123456789ABCDEFabcdef'

# This map construction is based on urllib's implementation
_HEX_TO_BYTE = dict(((a + b).encode(), bytes([int(a + b, 16)]))
for a in _HEX_DIGITS
for b in _HEX_DIGITS)
_HEX_TO_BYTE = {(a + b).encode(): bytes([int(a + b, 16)])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change we could actually keep. The old form probably could not use dict comprehension because it had to support Python 2.6.

for a in _HEX_DIGITS
for b in _HEX_DIGITS}

_PYPY = platform.python_implementation() == 'PyPy'

Expand Down