-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tutorial): port the ASGI tutorial #1737
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1737 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 5128 5128
Branches 823 823
=========================================
Hits 5128 5128 Continue to review full report at Codecov.
|
WiP: replace `birdisle` (it is getting stale/abandoned wrt new CPython versions) w/ smth else. Add "copy-paste under" directives `for setup.py` and `tox.ini`.
It's still a bit dull and repetitive, and I find things I'd like to change every time I reread it myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 🚀 .
I think we can avoid the copy-paste of code alltogheter by using the sphinx directive literalinclude that does exactly that for us.
I think we could also update the wsgi tutorial to use it.
Has an issue been created to track this? |
Now it has been created. 🙂 ⬆️ Thanks @CaselIT ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I just found a few minor things that would be good to address for our first beta. Before the second beta, there are a handful of grammatical nits that I can circle back on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements. Some grammatical odds and ends could be cleaned up to conform to the KGRIFFS Style Guide™ but we can circle back on those later.
Heh, it seems that joke stuck 🤣 (Patent pending) |
Closes #1713
Create a script to check that in-line snippets are in syncno longer neededasgilook
Travis CI gateREADME.rst
and all filesasgilook
tests in GitHub Actions