Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #21 convert org.faktorips.runtime #31

Closed
wants to merge 3 commits into from

Conversation

laeubi
Copy link
Collaborator

@laeubi laeubi commented Mar 26, 2022

This converts the org.faktorips runtime to maven

@laeubi
Copy link
Collaborator Author

laeubi commented Mar 26, 2022

I have created eclipse-tycho/tycho#806 so get better error output.

@laeubi laeubi marked this pull request as ready for review March 26, 2022 13:28
@laeubi
Copy link
Collaborator Author

laeubi commented Mar 26, 2022

This now builds successful and all tests are green.

@hd42
Copy link
Member

hd42 commented Mar 29, 2022

@laeubi, Die Testfehler scheinen den Build nicht zu stören: https://github.com/faktorips/faktorips.base/pull/31/checks#step:7:1338
Error: Tests run: 9, Failures: 2, Errors: 6, Skipped: 0, Time elapsed: 0.704 s <<< FAILURE! - in org.faktorips.runtime.util.MessagesHelperTest Error: testGetMessage_nullObject(org.faktorips.runtime.util.MessagesHelperTest) Time elapsed: 0.551 s <<< ERROR! java.util.MissingResourceException: Can't find bundle for base name org.faktorips.runtime.util.MessagesHelperTest, locale en at org.faktorips.runtime.util.MessagesHelperTest.testGetMessage_nullObject(MessagesHelperTest.java:73) ...
Die Fehler sehen mir danach aus, dass evtl. die resources nicht gefunden werden.

@laeubi
Copy link
Collaborator Author

laeubi commented Mar 29, 2022

Ja komisch, eigeltich sollte https://github.com/faktorips/faktorips.base/blob/FIPS-8557/.github/workflows/junit.yml die Unit-test ergebnisse einsameln da muss ich mal schauen wieso das nicht klappt.

@laeubi
Copy link
Collaborator Author

laeubi commented Mar 29, 2022

Okay hier steht das das nur geht wenn der Workflow auf dem "default" branch ist:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

spricht was dagegen die .github workkflows schon auf den master zu übernehmen? Durch den branch-name filter laufen die dort dan halt nicht sollte also auch nicht stören...

@hd42
Copy link
Member

hd42 commented Mar 29, 2022

spricht was dagegen die .github workkflows schon auf den master zu übernehmen? Durch den branch-name filter laufen die dort dan halt nicht sollte also auch nicht stören...

Erledigt: e608056

@laeubi
Copy link
Collaborator Author

laeubi commented Mar 29, 2022

Kannst du dann den maven build workflow noch einmal starten? Den junit workflow sehe ich schon mal https://github.com/faktorips/faktorips.base/actions/workflows/junit.yml

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

Unit Test Results

   998 files     998 suites   23m 45s ⏱️
8 282 tests 8 065 ✔️ 14 💤 7  196 🔥

For more details on these failures and errors, see this check.

Results for commit 2ac5aac.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Collaborator Author

laeubi commented Mar 30, 2022

Also so ein bischen funktionieren tut es ja schon ... immerhin ist schonmal der unit report da...

@hd42
Copy link
Member

hd42 commented Mar 31, 2022

Merged as dc57488

@hd42 hd42 closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants