Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese lorem words to locale #900

Merged
merged 6 commits into from
May 21, 2018
Merged

Add Japanese lorem words to locale #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1875c21
Added Japanese words to lorem ja locale
vietqhoang May 2, 2017
8a18bbd
Use punctuation specific to locale
vietqhoang May 2, 2017
02131b4
Added punctuation to en.yml. Remove fallbacks.
vietqhoang May 2, 2017
56ecff9
Addressed Rubocop violation
vietqhoang May 21, 2018
114ee63
Partial Revert "Added punctuation to en.yml. Remove fallbacks."
vietqhoang May 21, 2018
24cde31
Add punctuation defaults to lorem
vietqhoang May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/faker/lorem.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,23 @@ def characters(char_count = 255)
end

def sentence(word_count = 4, supplemental = false, random_words_to_add = 6)
words(word_count + rand(random_words_to_add.to_i), supplemental).join(' ').capitalize + '.'
words(word_count + rand(random_words_to_add.to_i), supplemental).join(' ').capitalize + locale_period
end

def sentences(sentence_count = 3, supplemental = false)
1.upto(resolve(sentence_count)).collect { sentence(3, supplemental) }
end

def paragraph(sentence_count = 3, supplemental = false, random_sentences_to_add = 3)
sentences(resolve(sentence_count) + rand(random_sentences_to_add.to_i), supplemental).join(' ')
sentences(resolve(sentence_count) + rand(random_sentences_to_add.to_i), supplemental).join(locale_space)
end

def paragraphs(paragraph_count = 3, supplemental = false)
1.upto(resolve(paragraph_count)).collect { paragraph(3, supplemental) }
end

def question(word_count = 4, supplemental = false, random_words_to_add = 6)
words(word_count + rand(random_words_to_add.to_i), supplemental).join(' ').capitalize + '?'
words(word_count + rand(random_words_to_add.to_i), supplemental).join(locale_space).capitalize + locale_question_mark
end

def questions(question_count = 3, supplemental = false)
Expand All @@ -54,6 +54,18 @@ def questions(question_count = 3, supplemental = false)

private

def locale_period
translate('faker.lorem.punctuation.period') || '.'
end

def locale_space
translate('faker.lorem.punctuation.space') || ' '
end

def locale_question_mark
translate('faker.lorem.punctuation.question_mark') || '?'
end

# If an array or range is passed, a random value will be selected.
# All other values are simply returned.
def resolve(value)
Expand Down
Loading