Add Faker::ElectricalComponents #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput when running rake task, all tests pass
… assertion for active class added, implementation in progress
b264
reviewed
Jan 17, 2017
lib/faker/electrical_components.rb
Outdated
| module Faker | ||
| class ElectricalComponents < Base | ||
| flexible :electrical_components | ||
| def active |
There was a problem hiding this comment.
With the flexible key above, can these methods be removed and the tests still pass?
There was a problem hiding this comment.
No they can not, I get NoMethodError: undefined method []' for nil:NilClass`` errors for each method if they are not present. I included this code because an error message from the test suite prompted me to: warning: instance variable @flexible_key not initialized.
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def
to
a5d7731
Compare
vbrazo
changed the title
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* test setup added for electrical components, test is included in test utput when running rake task, all tests pass * add require path to faker.rb, add elec component file in faker/, test assertion for active class added, implementation in progress * test passes for active method, more additions to come * add Electrical Components - active to docs * passive test passing, add passive components to en.yml * add docs for passive * add test and functionality for electromechanical components, all tests pass * add docs for electromechanical * remove unnecessary class << self code * fix spacing and indentation * Update changelog.md * Update readme.md * Minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, please review this PR for adding an assortment of electrical components to the Faker code base. I have included three methods or 'categories' of electrical components: active, passive, and electromechanical. Tests have been added and are passing; documentation has been added to reflect the categories with examples of each in the docs.