Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained History.md #2880

Merged

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Jan 3, 2024

Motivation / Background

This repository has History.md and CHANGELOG.md to record changes. But History.md hasn't been maintained since 2016. CHANGELOG.md has all the changes(including the same change as the History.md ) and there is no reason to keep this file I think.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

This repository has `History.md` and `CHANGELOG.md` to record changes.
But `History.md` hasn't been maintained since 2016. `CHANGELOG.md` has
all the changes(including the same change as the `History.md` ) and
there is no reason to keep this file I think.
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I wasn't aware of that file. Thanks!

@stefannibrasil stefannibrasil merged commit bd5cb78 into faker-ruby:main Jan 5, 2024
7 checks passed
@y-yagi y-yagi deleted the remove-unmaintained-history.md branch January 6, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants