Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefixes to french name locale (Faker::Name.name) #2800

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add prefixes to french name locale (Faker::Name.name) #2800

merged 1 commit into from
Jul 14, 2023

Conversation

thdaraujo
Copy link
Contributor

@thdaraujo thdaraujo commented Jul 14, 2023 •
edited
Loading

Motivation / Background

[fixes #2783]

Currently, Faker::Name.name will fetch a prefix from the en locale, because the fr locale doesn't have prefixes.

This PR adds french-specific prefixes.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@thdaraujo thdaraujo changed the title Add prefixes to french name locale Add prefixes to french name locale (Faker::Name.name) Jul 14, 2023
@thdaraujo thdaraujo mentioned this pull request Jul 14, 2023
Closed
@thdaraujo thdaraujo marked this pull request as ready for review July 14, 2023 03:12
@thdaraujo thdaraujo self-assigned this Jul 14, 2023
stefannibrasil
stefannibrasil approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefannibrasil stefannibrasil merged commit 576ca87 into main Jul 14, 2023
@stefannibrasil stefannibrasil deleted the ta/fr-name-prefix branch July 14, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees

@thdaraujo thdaraujo

Labels
⚒️ Improvement 🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR locale "name" broken
2 participants
@thdaraujo @stefannibrasil