Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Japanesemedia::CowboyBebop module #2617

Merged
merged 12 commits into from
Nov 6, 2022
Merged

Conversation

Ivan-P23994
Copy link
Contributor

Summary

Added a simple Faker module that enables users to generate data(characters, quotes, episodes, songs) from the renowned anime classic "Cowboy Bebop".

Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor change that's required.

doc/japanese_media/cowboy_bebop.md Outdated Show resolved Hide resolved
@psibi psibi merged commit 05a5e1e into faker-ruby:main Nov 6, 2022
@psibi
Copy link
Member

psibi commented Nov 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants