Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set true to rubygems_mfa_required gemspec metadata #2549

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

koic
Copy link
Member

@koic koic commented Aug 30, 2022

This PR sets true to rubygems_mfa_required gemspec metadata. It's important for security. Please note that MFA will be required upon release.
https://guides.rubygems.org/setting-up-multifactor-authentication/

cc @vbrazo

This PR sets `true` to `rubygems_mfa_required` gemspec metadata.
It's important for security. Please note that MFA will be required upon release.
https://guides.rubygems.org/setting-up-multifactor-authentication/
@koic koic requested a review from vbrazo August 30, 2022 00:23
koic referenced this pull request Aug 30, 2022
Note that `Gemspec/RequireMFA` is enabled.

Please refer to the article below for RubyGems MFA status.
https://blog.rubygems.org/2022/08/15/requiring-mfa-on-popular-gems.html
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @koic, this is awesome!

One question: does this apply to all maintainers or only when releasing a new version?

@dmarcoux
Copy link
Contributor

dmarcoux commented Sep 1, 2022

@stefannibrasil According to this, it's for all privileged operations. Those are:

  • gem push
  • gem yank
  • gem owner --add/remove
  • adding or removing owners using gem ownership page

@koic
Copy link
Member Author

koic commented Sep 1, 2022

Yup, this is for owners of https://rubygems.org/gems/faker.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vbrazo vbrazo merged commit f54db33 into faker-ruby:master Sep 1, 2022
@koic koic deleted the set_true_to_rubygems_mfa_required branch September 2, 2022 08:27
@stefannibrasil
Copy link
Contributor

really cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants