Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
Fixes #2521
Description:
Fixes some flaky tests on
test_faker_internet.rb
related to bot_user_agent generation.These previous test were matching against a fixed list of options for user agents and bot user agents.
The problem appeared when a new type of user agent was added to the locales. Because the generator randomly picks an user agent, the previous test would fail at random when the agent picked didn't match the regex.
But the generator should return a string even if the vendor is not available or the argument is invalid.
We can simply verify that the agent is present. Otherwise, we would have to keep the regex and these tests updated whenever a new user agent is added to the locale.