Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Japanese adjective translations #2490

Merged
merged 2 commits into from
May 19, 2022
Merged

Added Japanese adjective translations #2490

merged 2 commits into from
May 19, 2022

Conversation

yasuhiron777
Copy link
Contributor

Issue#

No-Story

Description:

Added Japanese adjective translations.

psibi
psibi approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. The test failures are unrelated to this PR and it seems master is already kind of broken starting from this change: ee00215

@psibi psibi merged commit 7846d10 into faker-ruby:master May 19, 2022
@psibi
Copy link
Member

psibi commented May 19, 2022

Thank you!

@yasuhiron777
Copy link
Contributor Author

@psibi
I just wanna say thank you for my PR merging in!
This is my first commit to OSS, small one though😉

@yasuhiron777 yasuhiron777 deleted the add-japanese-adjective-translations branch May 19, 2022 13:53
@vbrazo
Copy link
Member

vbrazo commented May 25, 2022

Welcome @yasuhiron777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psibi psibi psibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasuhiron777 @psibi @vbrazo