Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Command & Conquer games #2457

Merged
merged 1 commit into from
Jan 31, 2022
Merged

add Command & Conquer games #2457

merged 1 commit into from
Jan 31, 2022

Conversation

Awilum
Copy link
Contributor

@Awilum Awilum commented Jan 30, 2022

No description provided.

@vbrazo vbrazo merged commit c1998d0 into faker-ruby:master Jan 31, 2022
- 'Command & Conquer 4: Tiberian Twilight'
- 'Command & Conquer: Rivals'
- 'Command & Conquer: Tiberium Alliances'
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line being empty causes problems when this generator is used, I've had quite a few weird test failures because of it 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was fixed with #2469, could we cut a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants