Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::JapaneseMedia::KamenRider#transformation_device #2383

Merged

Conversation

boardfish
Copy link
Contributor

@boardfish boardfish commented Sep 4, 2021

Issue#

No-Story

Description:

Kamen Riders use certain devices (usually in the form of a belt) to transform. This PR provides the names of transformation devices from across all eras for the Faker class to use.

There might be inaccuracies in the data as I wasn't easily able to scrape these from the wiki, but I've tried to be meticulous about it.

@psibi
Copy link
Member

psibi commented Sep 6, 2021

Can you fix the conflicts ?

@boardfish boardfish force-pushed the kamen-rider-transformation-belts branch from 935bac1 to 9768fe2 Compare September 6, 2021 16:26
@boardfish
Copy link
Contributor Author

All sorted.

@psibi psibi merged commit 1482195 into faker-ruby:master Sep 6, 2021
@psibi
Copy link
Member

psibi commented Sep 6, 2021

Thank you!

@boardfish boardfish deleted the kamen-rider-transformation-belts branch September 7, 2021 09:23
aclemons pushed a commit to aclemons/faker that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants