Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rock_band.md to include example for using song generator #2240

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

jsca-kwok
Copy link
Contributor

No description provided.

@vbrazo
Copy link
Member

vbrazo commented Jan 11, 2021

@jsca-kwok could you please also remove the locale duplication as mentioned by Akira here?

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbrazo vbrazo merged commit 664cbaf into faker-ruby:master Jan 11, 2021
@jsca-kwok jsca-kwok deleted the update-rock-band-doc branch January 30, 2021 21:09
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants