Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate celebrity methods in favor of actor #2133

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Deprecate celebrity methods in favor of actor #2133

merged 2 commits into from
Oct 2, 2020

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Oct 1, 2020

Deprecated the 'Buffy.celebrity' and 'TheFreshPrinceOfBelAir.celebrity' methods with corresponding 'actor' methods.

Issue#

This PR fixes the following issue #1760

Description:

This PR fixes the issue reported.

…y' methods with corresponding 'actor' methods.
lib/faker/tv_shows/buffy.rb Outdated Show resolved Hide resolved
lib/locales/en/fresh_prince_of_bel_air.yml Show resolved Hide resolved
@Zeragamba Zeragamba changed the title Deprecated the 'Buffy.celebrity' and 'TheFreshPrinceOfBelAir.celebrit… Deprecate celebrity methods in favor of actor Oct 1, 2020
@Zeragamba Zeragamba merged commit 1922f66 into faker-ruby:master Oct 2, 2020
@Zeragamba
Copy link
Contributor

Thanks!

@vraravam vraravam deleted the replace-celebrity-with-actor branch October 2, 2020 12:56
droznyk pushed a commit to droznyk/faker that referenced this pull request Oct 23, 2020
* Deprecated the 'Buffy.celebrity' and 'TheFreshPrinceOfBelAir.celebrity' methods with corresponding 'actor' methods.

* Fixing version tag to be 'next'.
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants