Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional quotes to Studio Ghibli #2132

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

lambda2
Copy link
Contributor

@lambda2 lambda2 commented Oct 1, 2020

Issue#

No-Story

Description:

This pull request add additional quotes in the studio_ghibli generator from Porco Rosso and Laputa Ghibli movies.

lib/locales/en/studio_ghibli.yml Outdated Show resolved Hide resolved
@lambda2 lambda2 requested a review from Zeragamba October 1, 2020 16:53
@Zeragamba Zeragamba merged commit 33e2a63 into faker-ruby:master Oct 1, 2020
@Zeragamba
Copy link
Contributor

Thanks!

droznyk pushed a commit to droznyk/faker that referenced this pull request Oct 23, 2020
* feat(studio_ghibli): Add additional quotes from Porco Rosso and Laputa

* fix(studio_ghibli): remove unappropriate sentence
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants