Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Studio Ghibli #2124

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Add Studio Ghibli #2124

merged 1 commit into from
Sep 24, 2020

Conversation

Kadaaran
Copy link
Contributor

@Kadaaran Kadaaran commented Sep 21, 2020

Issue#

No-Story

Description:

  • Add Studio Ghibli to the JapanseMedia category
  • Add movies, characters and quotes
  • Set the version to next
  • ✅ Rubocop
  • ✅ Tests
  • ✅ Documentation
  • Rebased to 1 commit.

@Kadaaran Kadaaran changed the title Add Studio Ghibli to the JapaneseMedia category Add Studio Ghibli Sep 21, 2020
@psibi psibi merged commit ef44b03 into faker-ruby:master Sep 24, 2020
@psibi
Copy link
Member

psibi commented Sep 24, 2020

Thanks!

droznyk pushed a commit to droznyk/faker that referenced this pull request Oct 23, 2020
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants