-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling the usage of open compounds in sentences #2109
Allow disabling the usage of open compounds in sentences #2109
Conversation
cf31304
to
12f0867
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjozwik can we add test cases around new param that we are passing in sentence method? Apart from that PR looks good to me
@sudeeptarlekar tests cases added. |
@tjozwik can you please rebase branch with latest code, this will fix flaky failures. |
390736f
to
9ade240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will leave further process to @psibi, @Zeragamba.
Thanks! |
…2109) * Allow disabling using open compounds in sentences * Create tests for sentences with open compounds
…er-ruby#2109)" This reverts commit 5cbb62e.
…er-ruby#2109)" This reverts commit 5cbb62e.
Connected with: Issue #2102
Alternative solution fixing the same issue: #2108
Description
open_compounds_allowed
that allows to disable using open compounds ('words' containing additional spaces inside) inFaker::Hipster.sentence
andFaker::Books::Lovecraft.sentence
. By default the usage of open compounds would be allowed,random_words_to_add
param type in comment regardingFaker::Hipster.sentence
method.Additional info
faker.lovecraft.words
list butFaker::Books::Lovecraft.words
have a possibility of handling them, so it can be used after word list is updated,Faker::Lorem
but bothFaker::Lorem.words
doesn't have a possibility to treat open compounds differently than normal words, and there is no open compounds onfaker.lorem.words
list.