Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a street fighter generator #2092

Merged
merged 2 commits into from
Jul 26, 2020
Merged

Add a street fighter generator #2092

merged 2 commits into from
Jul 26, 2020

Conversation

royzwambag
Copy link
Contributor

Issue#

No-Story

Description:

Add a generator to generate a random character from the famous Street Fighter series.

Zeragamba
Zeragamba suggested changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one generator?

Could you include some more stuff to flesh this out a bit? Eg. Stages, Quotes, Combos, etc...

@royzwambag
Copy link
Contributor Author

@Zeragamba I added stages, quotes and moves

Zeragamba
Zeragamba approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now :)

@Zeragamba Zeragamba merged commit 8053bc3 into faker-ruby:master Jul 26, 2020
@Zeragamba
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royzwambag @Zeragamba