1693 USA driving license #2090
Merged
1693 USA driving license #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get any reviews on this PR? |
|
General comment on the MR: Do you think having something like this would be more nice: |
|
Full state names also sounds good to me, will change to use full state names |
sudeeptarlekar
force-pushed
the
1693-us-driving-license
branch
from
e0b1b1a
to
8b8b3e7
Compare
|
@psibi update state codes to names |
psibi
reviewed
Jul 31, 2020
|
@Zeragamba Mind giving the ruby code a review ? |
psibi
reviewed
Aug 7, 2020
psibi
reviewed
Aug 7, 2020
sudeeptarlekar
force-pushed
the
1693-us-driving-license
branch
from
c00a85f
to
659438e
Compare
|
@psibi added version and method doc, not sure why specs are failing on Ruby2.8. |
sudeeptarlekar
force-pushed
the
1693-us-driving-license
branch
from
659438e
to
0a078f4
Compare
psibi
reviewed
Aug 14, 2020
sudeeptarlekar
force-pushed
the
1693-us-driving-license
branch
from
0a078f4
to
8ebc948
Compare
psibi
approved these changes
Aug 15, 2020
|
Thanks for your contribution! |
tjozwik
pushed a commit
to tjozwik/faker
that referenced
this pull request
Sep 14, 2020
US driving licence for states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
resolves #1693
Description:
Added driving licence method for USA. Default state is California, you can generate licence number for states by passing the state argument to method