Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time formats from file #2072

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Conversation

GQuirino
Copy link
Contributor

@GQuirino GQuirino commented Jul 1, 2020

Issue#

#1978

Description:

This PR rollbacks part of this commit: 1977088, removing the keys from time.formats to not conflict main app locales files

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit 245215d into faker-ruby:master Jul 4, 2020
gabrielbaldao pushed a commit to gabrielbaldao/faker that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants