Update 'prepare' regexp to allow hyphen #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address failing specs
jbergenson
force-pushed
the
fix-email-domain-dash-issue
branch
from
72a9fe3
to
2fe184f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1954
Description:
Fix edge case where domain has a hyphen in it (example:
foo-bar.com) by updating regexp inFaker::Char.prepareand update test assertion to account for change.The only other place where I see this change having an impact is in
Faker::Internet.username, however there are currently no names in the locale file that contain a hyphen and so it seems like it would be overkill to account for this in thepreparemethod.