Make locale self-contained #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the final MR which makes the locale self-cotained. This came out of my work at https://github.com/psibi/fakedata I have been fixing the non working parts of the faker locales from last year and have been documenting things which doesn't work: https://github.com/psibi/fakedata/blob/master/Development.md#known-locale-issues This MR fixes all of them and with this fix - the Haskell client will become on par with the Ruby. (It still lag behinds becomes it's tracking via git submodule - but it will completely support all the feature for the particular submodule!)
Zeragamba
suggested changes
May 25, 2020
Zeragamba
approved these changes
May 26, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final MR which makes the locale self-cotained. This came
out of my work at https://github.com/psibi/fakedata
I have been fixing the non working parts of the faker locales from
last year and have been documenting things which doesn't work:
https://github.com/psibi/fakedata/blob/master/Development.md#known-locale-issues
This MR fixes all of them and with this fix - the Haskell client will
become on par with the Ruby. (It still lag behinds becomes it's
tracking via git submodule - but it will completely support all the
feature for the particular submodule!)