-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ruby testing github workflow #1994
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d65ebb0
Enable Ruby testing github workflow
Zeragamba 0210c17
change `ruby-version` => `ruby` in matrix
Zeragamba 6fef819
disable fail-fast
Zeragamba 3bad6dd
Use lastest of each minor version
Zeragamba 84910ed
add code climate reporting
Zeragamba 056f0c0
Use the GitHub action badge in the README
Zeragamba ea77b0d
link directly to tests
Zeragamba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # This workflow uses actions that are not certified by GitHub. | ||
| # They are provided by a third-party and are governed by | ||
| # separate terms of service, privacy policy, and support | ||
| # documentation. | ||
| # This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake | ||
| # For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby | ||
|
|
||
| name: Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Ruby ${{ matrix.ruby }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false # don't fail all matrix builds if one fails | ||
| matrix: | ||
| ruby: | ||
| - '2.3' | ||
| - '2.4' | ||
| - '2.5' | ||
| - '2.6' | ||
| - '2.7' | ||
| - 'head' | ||
| continue-on-error: ${{ endsWith(matrix.ruby, 'head') }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
|
|
||
| - name: Install dependencies | ||
| run: bundle install | ||
|
|
||
| - name: Setup Code Climate test-reporter | ||
| run: | | ||
| curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter | ||
| chmod +x ./cc-test-reporter | ||
| ./cc-test-reporter before-build | ||
| - name: Run tests | ||
| run: bundle exec rake | ||
|
|
||
| - name: Publish code coverage | ||
| env: | ||
| CC_TEST_REPORTER_ID: c9b8356df2031a5a72462555fe898245cf24d83c7bb82c40ddb5c6c6976c4319 | ||
| # CC_TEST_REPORTER_ID: ${{ secrets.CodeClimateReporterId }} | ||
| run: | | ||
| export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}" | ||
| ./cc-test-reporter after-build -r $CC_TEST_REPORTER_ID | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 is this supposed to be a secret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it was also in the .travis.yml file. @stympy (or someone with
adminperms) will need to move it to the repo's secrets and regenerate it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I have access to the Travis account. I wonder if we should create a new GitHub user for Faker and assign these responsibilities to this user. I like this idea because all the members of the Faker organization would be able to change the settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this codeclimate/ruby-test-reporter#34, I guess we should be ok to keep this key public.