-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
en-AU locale updates #1964
en-AU locale updates #1964
Conversation
…st); en-AU locale updates including name's for banks and universities, vehicle registration/license plates, postcode tweaks
Changes look good, however the conflicts need to be resolved |
Hey @Zeragamba, thanks for your feedback :) that conflict with the other commit that added docs to Faker::Bank has been resolved now (I think I did it right?) |
…Faker::Vehicle while testing that is corrected in this update
Thanks! |
Thanks for your help and that of @Zeragamba getting it to a point it could be merged! :) |
@psibi remember to squash and merge pull requests. Keeps the history nice and clean. :) |
@Zeragamba Sorry about that! Will make sure to squash in future. Thanks! |
@mattman I only just came across the ACMA list of allowable fake numbers and thought that would be a great addition to Faker. Started digging around and quickly found your PR. Great, it's already done! Thanks very much for adding it in. Now I can update faker and start using it straight away. |
Description:
Updates the en-AU locale file with the following changes:
New method in Faker::Bank
New method
Faker::Bank.bsb_number
(and supporting private method following same conventions as existing code) introduced as Australian banks do not use the routing format that was already in the code base so a new method was written using some of the recognised bank codes to generate BSB (Bank-State-Bank) numbersHope this is ok, first time I've done a pull request so welcome your feedback on how to do this better, thank you for an awesome tool! :)