Introduce Faker::Quotes::Chiquito #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce intended data structure for the text file
julitrows
changed the title
psibi
reviewed
Feb 28, 2020
| "Uno que nació después de los dolores" | ||
| ] | ||
| jokes: [ | ||
| "- Papár papár llévame al circo!\n |
There was a problem hiding this comment.
I don't know Spanish, but does these characters required:
\n-
There was a problem hiding this comment.
These jokes are in the form of a dialogue written in Spanish, hence:
a. the - to introduce one characer speaking (I think in English this is done by opening quotes?)
b. the newline to separate when each character involved speaks
Perhaps there's a format in English that is friendlier?
There was a problem hiding this comment.
Ah, I see. I guess it's okay then.
iovis
reviewed
Feb 28, 2020
iovis
reviewed
Feb 28, 2020
iovis
reviewed
Feb 28, 2020
iovis
reviewed
Feb 28, 2020
iovis
reviewed
Feb 28, 2020
|
Hehehe look at that Travis build failing because of leap year musings :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription
The late Gregorio Esteban Sánchez Fernández, popularly known as Chiquito de la Calzada, was a Spanish showman that revolutionized the use of the Spanish language with his crazy invented words and funny expressions.
He was a TV show star but also did movies and even lend his voice as samples to music recordings.
To this day, he's still one of the most prominent Andalusian figures to have ever existed, and this PR is but a humble homage to his figure and legacy.
This Faker can and will be used as generator for random text.
Additional Information and Inspiration