Add Faker::Movies::Departed Class #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to select actors, characters, or quotes from the movie, The Departed.
jaebradley
commented
Feb 12, 2020
| @@ -0,0 +1,11 @@ | |||
| # Faker::Movies::Departed | |||
|
|
|||
| Available since version next. | |||
There was a problem hiding this comment.
Feel free to adjust this version value - I might have missed how to generate the next version (I did peek at the contribution guide, but could have misread the section on document generation).
There was a problem hiding this comment.
For these docs, I don't think we keep track of when a set of generators were added.
|
@Zeragamba and @vbrazo are you folks the right people to tag for review? If not, please let me know so I can request review from those people. Thanks! |
lucasqueiroz
approved these changes
Apr 11, 2020
Zeragamba
approved these changes
May 19, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to select actors, characters, or quotes from the movie,
The Departed.The quotes were copied from
IMDB.The actors and characters were copied from
IMDB.When character names were incomplete on the
IMDBwebsite, they were corroborated against usingThe Departed Wiki.Issue#
No-StoryDescription
I envision using the class's character and actor names to populate the names of various test factories as well as using the quotes to populate text fields.