Add faker for hiphop artist #1923
Conversation
lib/faker/music/hiphop.rb
Outdated
| # @example | ||
| # Faker::Music::Hiphop.group #=> "OVO" | ||
| # | ||
| # @faker.version 1.9.2 |
There was a problem hiding this comment.
should be @faker.version next so that we can just find and replace when this gets merged
lib/faker/music/hiphop.rb
Outdated
| # @example | ||
| # Faker::Music::Hiphop.artist #=> "Lil Wayne" | ||
| # |
lib/faker/music/hiphop.rb
Outdated
| # @return [String] | ||
| # | ||
| # @example | ||
| # Faker::Music::Hiphop.group #=> "OVO" |
There was a problem hiding this comment.
example shows the wrong method
|
@Zeragamba if you got a chance |
lib/faker/music/hiphop.rb
Outdated
| # Faker::Music::Hiphop.groups #=> "OVO" | ||
| # | ||
| # @faker.version next | ||
|
|
There was a problem hiding this comment.
Extra space here that can be removed
lib/locales/en/hiphop.yml
Outdated
| @@ -0,0 +1,127 @@ | |||
| en: | |||
| faker: | |||
| hiphop: | |||
There was a problem hiding this comment.
Can we shift this down to en.faker.music.hiphop?
There was a problem hiding this comment.
@Zeragamba got all the comments knocked out.
lib/faker/music/hiphop.rb
Outdated
| end | ||
|
|
||
| ## | ||
| # Produces the name of a Hip Hop Group |
lib/locales/en/music.yml
Outdated
| @@ -30,3 +30,14 @@ en: | |||
| "Flashdance: Original Soundtrack from the Motion Picture", "Whitney", "Confessions", "X&Y", "High School Musical", "High School Musical 2", "Viva la Vida or Death and All His Friends", | |||
| "I Dreamed a Dream", "Recovery", "Midnight Memories", "Frozen", "Lemonade", "Brand New Eyes", "All We Know Is Falling", "Riot!", "Songs About Jane", "Hands All Over"] | |||
| genres: ["Rock", "Pop", "Electronic", "Folk", "World", "Country", "Jazz", "Funk", "Soul", "Hip Hop", "Classical", "Latin", "Reggae", "Stage And Screen", "Blues", "Non Music", "Rap"] | |||
| hiphop: | |||
There was a problem hiding this comment.
We would prefer single item per line for yaml arrays so that it's easier to see when something is added or removed
There was a problem hiding this comment.
can you past an example so I do it right @Zeragamba
There was a problem hiding this comment.
Sorry for the radio silence. Check CONTRIBUTING.md
There was a problem hiding this comment.
should be fixed now @Zeragamba
|
Thanks! |
* add faker for hiphop artist * update faker docs * update comments based on feedback * clean up * reformat
This reverts commit 01494d4.
This reverts commit 01494d4.
This PR adds names of Hip Hop Artist & Groups to Faker Gem For Users to use