Add yard docs for Faker::Company #1915
Conversation
kos31de
force-pushed
the
add-yard-docs-for-company
branch
from
99bf7c5
to
d00515a
Compare
There was a problem hiding this comment.
For the comments, I think that it is best to follow the standard practise that has been used throughout this library.
So instead of Produces a company duns_number., it should be Produces a company duns number.
And maybe it would be worth adding an extra blank line between the @faker.version and the useful developer comments, just to keep it clear that the two are not related to each other 😄
|
@mrstebo
|
lib/faker/default/company.rb
Outdated
| # When a straight answer won't do, BS to the rescue! | ||
| def bs | ||
| translate('faker.company.bs').collect { |list| sample(list) }.join(' ') | ||
| end | ||
|
|
||
| ## | ||
| # Produces a company ein. |
There was a problem hiding this comment.
Should clarify what an EIN is.
| # Produces a company ein. | |
| # Produces a company EIN (Employer Identification Number). |
There was a problem hiding this comment.
@connorshea
Thank you for your suggestion.
I fixed it.
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
…into add-yard-docs-for-company
|
@mrstebo |
Co-Authored-By: Steven Atkinson <mrstebouk@gmail.com>
|
@mrstebo |
Issue#1762
Part of #1762.
Description:
Add yard docs for
Faker::CompanyAvoid rubocop warning by replacing Spanish URL with % encoded URL