Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the path names for bg.yml #1877

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Conversation

psibi
Copy link
Member

@psibi psibi commented Dec 28, 2019

The fields doesn't need to use the 'Address' prefix for referring as it's already inside the address subfield for this locale. Note that other locales like ar.yml, follow this properly.

Note that having it like this affects my Haskell client which relies on the faker's data source. Relevant MR which found this bug: fakedata-haskell/fakedata#9

The fields doesn't need to use the 'Address' prefix for referring as
it's already inside the `address` subfield for this locale. Note that
other locales like `ar.yml`, follow this properly.

Note that having it like this affects my Haskell client which relies
on the faker's data source. Relevant MR which found this bug:
fakedata-haskell/fakedata#9
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks 👍

@vbrazo vbrazo merged commit 31551b1 into faker-ruby:master Dec 28, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
The fields doesn't need to use the 'Address' prefix for referring as
it's already inside the `address` subfield for this locale. Note that
other locales like `ar.yml`, follow this properly.

Note that having it like this affects my Haskell client which relies
on the faker's data source. Relevant MR which found this bug:
fakedata-haskell/fakedata#9
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
The fields doesn't need to use the 'Address' prefix for referring as
it's already inside the `address` subfield for this locale. Note that
other locales like `ar.yml`, follow this properly.

Note that having it like this affects my Haskell client which relies
on the faker's data source. Relevant MR which found this bug:
fakedata-haskell/fakedata#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants