Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phone number documentation #1862

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Update phone number documentation #1862

merged 2 commits into from
Dec 17, 2019

Conversation

davidmyersdev
Copy link
Contributor

No-Story

Description

This PR does 2 things:

  • updates the Faker::PhoneNumber documentation to help explain the difference between .phone_number and .cell_phone
  • removes duplicate formats from the phone_number formatter

davidmyersdev and others added 2 commits December 12, 2019 10:04
@davidmyersdev
Update Faker::PhoneNumber documentation
1b05282 
This helps explain the difference between the `.phone_number` and `.cell_phone` formatters.
@davidmyersdev
Remove duplicate phone_number formats
0643be1
@asajdak
Copy link

asajdak commented Dec 12, 2019

Thank you! This would have helped me understand what faker was doing in a recent use case I had

vbrazo
vbrazo approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for submitting this :)

@vbrazo vbrazo merged commit 233a923 into faker-ruby:master Dec 17, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@davidmyersdev @michebble
Update phone number documentation (faker-ruby#1862)
96ef8f5 
* Update Faker::PhoneNumber documentation

This helps explain the difference between the `.phone_number` and `.cell_phone` formatters.

* Remove duplicate phone_number formats
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@davidmyersdev @vbrazo
Update phone number documentation (faker-ruby#1862)
0f1a042 
* Update Faker::PhoneNumber documentation

This helps explain the difference between the `.phone_number` and `.cell_phone` formatters.

* Remove duplicate phone_number formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@davidmyersdev davidmyersdev

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmyersdev @asajdak @vbrazo