Fix Educator methods returning bad data. #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`name` is already registered on classes in Ruby, so it just returns Faker::Educator instead of a value from the name list. Fix the problem by renaming the key to school_name.
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
`name` is already registered on classes in Ruby, so it just returns Faker::Educator instead of a value from the name list. Fix the problem by renaming the key to school_name.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
`name` is already registered on classes in Ruby, so it just returns Faker::Educator instead of a value from the name list. Fix the problem by renaming the key to school_name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
Fixes #1857.
Description:
nameis already registered on classes in Ruby, so it just returnsFaker::Educatorinstead of a value from the name list. This fixes the problem by renaming the key toschool_name.