Makes minor refactors on Internet.domain_name method #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Dec 6, 2019
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Makes minor refactors on Internet.domain_name method * Fixes block-code style (rubocop complaints) * Fixes rubocop offense on method call
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Makes minor refactors on Internet.domain_name method * Fixes block-code style (rubocop complaints) * Fixes rubocop offense on method call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a minor refactor over #1846 that had a small typo and the code could be a little bit more rubyesque.