-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add YARD doc for Faker::Coin #1803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions, other than that it looks good to me. Thanks!
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
* add coin docs * Update lib/faker/default/coin.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/coin.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
* add coin docs * Update lib/faker/default/coin.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/coin.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Issue#
#1762
Description:
Add complete YARD docs for Faker::Coin methods.