Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo from bread to breed #1748

Merged
merged 1 commit into from
Sep 17, 2019
Merged

fix typo from bread to breed #1748

merged 1 commit into from
Sep 17, 2019

Conversation

4geru
Copy link
Contributor

@4geru 4geru commented Sep 17, 2019 •
edited
Loading

test expect breed.

faker/test/test_ja_locale.rb

Lines 46 to 48 in 839bfed

def test_ja_dog_methods
assert Faker::Creature::Dog.breed.is_a? String
end

vbrazo
vbrazo approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit 0bca93b into faker-ruby:master Sep 17, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@4geru @michebble
fix typo from bread to breed (faker-ruby#1748)
36e6fc0
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@4geru @vbrazo
fix typo from bread to breed (faker-ruby#1748)
8d6b137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@4geru 4geru

Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4geru @vbrazo