Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop #1721

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Update rubocop #1721

merged 4 commits into from
Sep 3, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Sep 2, 2019 •
edited
Loading

Issue#

#1720

Description:

  • Upgrade rubocop to 0.74.0 and fix rubocop offenses
  • Fix i18n syntax in faker.gemspec

@vbrazo vbrazo requested review from Zeragamba and bpleslie September 2, 2019 23:24
@vbrazo vbrazo self-assigned this Sep 2, 2019
@vbrazo vbrazo added the dependencies Pull requests that update a dependency file label Sep 2, 2019
@vbrazo vbrazo requested a review from lucasqueiroz September 2, 2019 23:33
bpleslie
bpleslie approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vbrazo vbrazo merged commit 9fd0ab5 into master Sep 3, 2019
@vbrazo vbrazo deleted the update-gemspec branch September 3, 2019 00:27
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@vbrazo @michebble
Update rubocop (faker-ruby#1721)
fbab04e 
* Update rubocop to 0.74.0

* Fix i18n sintaxe

* Use 1.17.3
@aleksandrs-ledovskis
Copy link

aleksandrs-ledovskis commented Apr 28, 2020 •
edited
Loading

N.B. This PR and consequently faker v2.2.2 has unannounced major dependency bump for i18n, which by consequence limits faker versions at v2.2.1 for projects stuck with Rails 4.x.

Not sure what was the reasoning for it, as commit is super vague. There's no entry in CHANGELOG either.

Yes, I know that current versions of Faker have even higher I18n requirements, and that Rails 4.x are EOL. This is just a grumble.

davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Update rubocop (faker-ruby#1721)
72d0544 
* Update rubocop to 0.74.0

* Fix i18n sintaxe

* Use 1.17.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpleslie bpleslie bpleslie approved these changes

@lucasqueiroz lucasqueiroz lucasqueiroz approved these changes

@Zeragamba Zeragamba Awaiting requested review from Zeragamba

Assignees

@vbrazo vbrazo

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbrazo @aleksandrs-ledovskis @bpleslie @lucasqueiroz