Adds Faker::Music::Prince #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
approved these changes
Aug 13, 2019
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a2a9f17
to
4384168
Compare
|
Today is Prince's birthday. Would be really cool (and make him really proud) if you merged this today. Give the people what they want! |
Zeragamba
suggested changes
Jun 7, 2020
Zeragamba
approved these changes
Jun 8, 2020
|
Woohoo! Long live Prince and long live the Faker gem! 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Prince class within Music parent class.
Adds
prince.ymlfile with 75+ lyrics, 90+ songs, 39 albums, and 7 of his associated bands.Adds
test_faker_prince.rbfile and passes tests.Adds
doc/music/prince.mdfile to show example usage and links it inREADME.md.Lints everything w/ rubocop.