Add full current list of (non-cover) Phish tunes from phish.net #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd and not covers
|
I realized that before this also had Trey Anastasio's solo work, which Phish often plays as their own. I think I'll add that before merge so no songs were lost to keep things backwards-compatible with expectations. |
vbrazo
approved these changes
Mar 19, 2019
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
…nd and not covers (faker-ruby#1581)
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
…nd and not covers (faker-ruby#1581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are from http://phish.net/song - it is all songs that are listed as by the band themselves and not a cover. Tests are green, the Rubocop seems happy. I'm resisting making Phish puns super hard. I was just gonna add Kasvot Vaxt but figured it wouldn't hurt to just get all the latest. Can get an exact diff if anyone cares particularly passionately about the list of Phish tunes and/or things were excluded with reason.