Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yaml format in docs #1496

Merged
merged 12 commits into from
Dec 24, 2018
Merged

Update yaml format in docs #1496

merged 12 commits into from
Dec 24, 2018

Commits on Dec 17, 2018

  1. add rake task to read and rewrite all yaml file 

    `bundle exec rake reformat_yaml`

Annoyingly... the standard YAML dump library used by Ruby doesn't provide a lot of formatting options (pretty much just indentation)
    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    1a8a604 View commit details
    Browse the repository at this point in the history

  2. reformat all yaml files 

    Comments were lost due to the parser not caring about them. We can manually go through and restore comments.
    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    9294ad5 View commit details
    Browse the repository at this point in the history

  3. please the rubocop

    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    d08f676 View commit details
    Browse the repository at this point in the history

  4. allow for passing a filepath to reformat a single file

    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    3ca9f41 View commit details
    Browse the repository at this point in the history

  5. update CONTRIBUTING.md to include yaml syntax guidelines

    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    df39c22 View commit details
    Browse the repository at this point in the history

  6. i did not obey the rubocop...

    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    8810f56 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into reformat-yaml

    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    a25910a View commit details
    Browse the repository at this point in the history

  8. update readmes

    @Zeragamba
    Zeragamba committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    5c5a661 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Revert "reformat all yaml files" 

    This reverts commit 9294ad5.
    @Zeragamba
    Zeragamba committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    0f6426e View commit details
    Browse the repository at this point in the history

  2. update task reformat_yaml to only work on one file

    @Zeragamba
    Zeragamba committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    4b0437f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into reformat-yaml

    @Zeragamba
    Zeragamba committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    5c773d6 View commit details
    Browse the repository at this point in the history

  4. use ' instead of "

    @Zeragamba
    Zeragamba committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    0e334eb View commit details
    Browse the repository at this point in the history